On Mon, 29 Jun 2026 17:52:32 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> "linux" means "unix but not macOS" > > modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaFeatures.java > line 58: > >> 56: "android", PlatformUtil::isAndroid, >> 57: "ios", PlatformUtil::isIOS, >> 58: "linux", PlatformUtil::isUnix, // for our purposes, "linux" >> means "unix but not macOS" > > I wonder if the GTK aspect is more important here, and also in the > `cssref.html`? > It's not about file path separators or some such, it's about GUI toolkit, > isn't it? Yes, you're right that the purpose of this media query is not so much technicalities like file separators. I'd say that it is more about the "look and feel" of the OS, and how style themes can adapt to it. In this sense, it also isn't about whether JavaFX uses GTK to show the window, or whether it uses some other way to achieve the same thing. So it's not about GTK, but then again "linux" is also not a precisely-defined look-and-feel. However, if you conducted a survey, I think you'd find that in actual usage, "linux" _does_ imply a certain look-and-feel, at least to an extent (because most people don't use exotic distros). And that's probably the only utility you'll get out of this particular media query. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2193#discussion_r3493785770
