On Tue, 30 Jun 2026 19:21:08 GMT, Andy Goryachev <[email protected]> wrote:

>> Marius Hanl has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains four additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'master' of https://github.com/openjdk/jfx into 
>> 8386663-Stylesheet/StyleClass-list-should-be-lazily-initialized
>>  - MenuItem toString() should also use the new styleClass way.
>>    
>>    TwoLevelFocusListBehavior was very weirdly relying on the toString() 
>> behavior
>>  - Move styleClass.toString into Node.toString()
>>  - 8386663: Stylesheet/StyleClass list should be lazily initialized
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/ParentTest.java line 
> 113:
> 
>> 111:         assertNull(stylesheets);
>> 112: 
>> 113:         Group g = new Group();
> 
> The `node` is never attached to the `Group` or the scene graph, same issue.

Good catch, I missed that somehow. Should be inside the `Group`. The 
`stageLoader` can not be used here unfortunately so I somehow missed that when 
writing the stage setup manually.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2191#discussion_r3501676048

Reply via email to