On Wed, 1 Jul 2026 20:14:45 GMT, Andy Goryachev <[email protected]> wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into commonmenus
>> - Tweaked testing utility that searches NSApp.mainMenu, added tests
>> - Merge remote-tracking branch 'upstream/master' into commonmenus
>> - New way of testing system menu bar, updated tests
>> - Merge remote-tracking branch 'upstream/master' into commonmenus
>> - Quick fix for a javadoc issue.
>> - Merge remote-tracking branch 'upstream/master' into commonmenus
>> - Specify a list of menus that are always present in the system menu bar
>
> tests/system/src/test/java/test/javafx/scene/control/CommonSystemMenusTest.java
> line 51:
>
>> 49: import test.util.Util;
>> 50:
>> 51: public class CommonSystemMenusTest {
>
> Does this PR impact swing/fx interop? If yes, shouldn't we have more tests
> that verify that the system menus are correctly handled between swing and fx?
Yes, the Swing/JFX interop tests should be expanded. The interop code between
Swing and JavaFX happens at a lower level so it should all work but, yes, it
should be tested. That would be part of a re-write of the manual test cases
that's already on my plate.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1881#discussion_r3509660586
