On Tue, 30 Jun 2026 16:05:06 GMT, Kevin Rushforth <[email protected]> wrote:
>> [Visual Studio 2026 May >> Update](https://learn.microsoft.com/en-us/visualstudio/releases/2026/release-notes#may-update-1860) >> (see C++ > MSVC Build Tools 14.51 > Standard Library (STL) > Other notable >> changes) removed support for some old, deprecated and non-standard STL >> extensions, including `hash_map` and `hash_set`. Both of these were used in >> `GlassClipboard`'s Windows part. Because of this change, JavaFX does not >> build under Visual Studio 2026 18.6 and later. >> >> This commit replaces deprecated `hash_map` and `hash_set` with STL-equvalent >> `unordered_map` and `unordered_set`. `GlassClipboard` also used (also >> deprecated) `hash_value` template function to calculate hashes for >> non-standard WinAPI object `_bstr_t` and `FORMATETC` ~~(the latter was >> implicitly generated by the extension)~~. Those were also replaced with >> STL-endorsed `std::hash` specializations. No other changes were necessary. >> >> All tests on Windows 11 pass successfully after this change and manual >> testing showed no regressions. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > @arapte Can you be the second reviewer? @kevinrushforth @arapte can you re-review when you have a moment? ------------- PR Comment: https://git.openjdk.org/jfx/pull/2198#issuecomment-4867319310
