On Mon, 6 Jul 2026 19:48:22 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add sentence to javadoc
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line
> 744:
>
>> 742:
>> 743: if (scene.getEffectiveNodeOrientation() !=
>> getEffectiveNodeOrientation()) {
>> 744: leftSystemPaddingWidth = isLeftSystemPadding() ?
>> properties.rightSystemInsetProperty().get().getWidth() : 0;
>
> still think it was a mistake with left/right instead of leading/trailing.
I agree, but this mistake was made over a decade ago. At this point,
introducing inconsistency doesn't help anyone...
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2188#discussion_r3531824865
