On Mon, 6 Jul 2026 22:03:37 GMT, Andy Goryachev <[email protected]> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Use CssParser.errorProperty()
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java
>  line 975:
> 
>> 973:     @Test
>> 974:     void testLookupResolvesWithPseudoClassAndIntermediatePane() {
>> 975:         var errors = StyleManager.errorsProperty();
> 
> should we use `CssParser.errorsProperty()` instead here?
> 
> (they are the same, but the `CssParser` is a public API while this one is not)

I don't see a reason against using `CssParser`, so sure, changed just now

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2201#discussion_r3537469095

Reply via email to