On Fri, 10 Jul 2026 00:07:16 GMT, Michael Strauß <[email protected]> wrote:

>> Today we can seal the interface. I doubt there's a significant cost here.
>
> While it most likely won't have an impact on performance (the JVM will do 
> class hierarchy analysis to figure out that `ListenerManager` and 
> `OldValueCachingListenerManager` are the only subclasses of 
> `ListenerManagerBase`), I think it's a good idea to seal this class to 
> document intent.

I can seal the base class, but sealing the subtypes is a bit more annoying 
(they have anonymous implementations) so I think I would leave those non-sealed 
for now.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r3558690857

Reply via email to