On Wed, 15 Jul 2026 06:16:21 GMT, Ambarish Rapte <[email protected]> wrote:
>> Update Webkit to v625.1 >> Build and sanity testing on Mac, Linux and Windows platforms is all green. >> >> Please note that this PR will be integrated after the fork of jfx27. >> >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > review corrections Thanks for the review. The review comments are addressed now. > 1. `WebPage.cpp`: ASERT is removed and m_printContext is not set to nullptr. `Java_com_sun_webkit_WebPage_twkDoJSCGarbageCollection` function is corrected to make the GC call > > 2. `WebKitLogging.cpp`: > 3. `JavaNodeFilterCondition.(h|cpp)`: It was a bad merge, the files are reverted. And for this update, there is no change required in these files. > `RenderThemeJava.cpp`: > A. Line 121 : > ``` > - Color bgColor = object.style().visitedDependentColor( > - widgetIndex == JNI_EXPAND(MENU_LIST_BUTTON) > - ? CSSPropertyColor > - : CSSPropertyBackgroundColor > - ); > + Color bgColor = widgetIndex == JNI_EXPAND(MENU_LIST_BUTTON) > + ? object.selectionForegroundColor() > + : object.selectionBackgroundColor(); > ``` This is now changed as below, to obtain the color from the RenderStyle object, to match with the upstream webkit [change](https://github.com/WebKit/WebKit/commit/79f21948053b671252d6c74362218c6807247f41). - ? object.selectionForegroundColor() - : object.selectionBackgroundColor(); + ? object.style().visitedDependentColor() + : object.style().visitedDependentBackgroundColor(); > B. Line 548: > > ``` > +RefPtr<FragmentedSharedBuffer> > RenderThemeJava::mediaControlsImageDataForIconNameAndType(const String& > iconName, const String& iconType) > +{ > + if (iconType != "svg") { > + return nullptr; > + } > ``` > Is this sufficient? Will we ever see an iconType other than `svg` (e.g., > `png`)? Currently only SVG media-control icons are supported, all callers request only SVGs and all required SVGs are present in the imageMap. so this check suffices. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2207#issuecomment-4977643669
