On Wed, 15 Jul 2026 11:31:01 GMT, Ambarish Rapte <[email protected]> wrote:

> Adding Linux aarch64 in GHA build. The required change is very minor.
> Similar to difference between macOS x64 and aarch64, the linux x64 and 
> aarch64 differ in,
> - name
> - runs-on platform name
> - BOOT_JDK_FILENAME
> - BOOT_JDK_URL
> 
> Verification:
> - The GHA build completed successfully on Linux aarch64 platform
> - The build log is as expected, with a few differences in the timestamp, 
> hashes, gradle thread names, etc.
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

LGTM with one inline comment. I'll approve once you address it.

.github/workflows/submit.yml line 160:

> 158:       # BOOT_JDK_FILENAME: "${{ 
> fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_FILENAME
>  }}"
> 159:       # BOOT_JDK_URL: "${{ 
> fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_URL }}"
> 160:       # BOOT_JDK_SHA256: "${{ 
> fromJson(needs.prerequisites.outputs.dependencies).LINUX_X64_BOOT_JDK_SHA256 
> }}"

For clarity, I recommend changing these to `LINUX_AARCH64_*`, even though they 
are commented out.

-------------

PR Review: https://git.openjdk.org/jfx/pull/2214#pullrequestreview-4704990678
PR Review Comment: https://git.openjdk.org/jfx/pull/2214#discussion_r3588040382

Reply via email to