On Thu, 16 Jul 2026 03:34:07 GMT, Ambarish Rapte <[email protected]> wrote:

> This is a very simple change for avoiding a warning repeated for 1570 times.
> 
> When JavaFX is built with `--info` gradle option, (`gradle --info` .... ).
> 1570 warnings are printed, like the one below here:
> 
> Cannot infer source root(s) for source `file 
> '/Users/runner/work/jfx/jfx/jfx/modules/javafx.graphics/src/main/java/javafx/css/Size.java'`.
>  Supported types are `File` (directories only), `DirectoryTree` and 
> `SourceDirectorySet`.
> 
> 
> **Fix**: is to change how the source directories are specified for graphics 
> module.
> 
> **Verification**: 
> 0 warnings of above type.
> The build artifacts are exact same as before, and sanity testing is all good.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks good.

Functionally equivalent in this context since the task starts with no sources. 
Also a cleaner use of the 
[SourceTask.source()](https://docs.gradle.org/current/dsl/org.gradle.api.tasks.SourceTask.html#org.gradle.api.tasks.SourceTask:source(java.lang.Object[]))
 API.

-------------

Marked as reviewed by mhanl (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2216#pullrequestreview-4712346754

Reply via email to