On Mon, 20 Jul 2026 10:15:19 GMT, Marius Hanl <[email protected]> wrote:
> Overall, this looks good. Nice to see some documentation for the > `CssStyleHelper` and related classes! Tests look nice as well and you > explained all scenarios very well. > > And it is great to see the removal of `forceSlowpath`, which during my > debugging was hard for me to understand why it even exists. It existed for when CSS metadata changed for a Node (so almost specifically to support what `Control` does with its changeable CSS metadata). When force slow path is on, it would lookup all defined CSS properties for that Node, and add them to the shared cache entry (the shared cache entry is not reset for this as many other nodes can be using it) to ensure that all CSS properties that should have a value are part of the shared cache entry, specifically if the Node's CSS metadata change introduced new CSS properties not seen before. If it didn't do this, then a newly discovered CSS property would not be added to the shared cache entry, and then its absence would later be interpreted as "unstyled" while it really was simply "not evaluated". This problem is gone in the new implementation because absence is always treated as "must be re-evaluated", resulting in either a `CalculatedValue` or `SKIP` being added for any CSS properties that were missing (even after a CSS metadata change). > > Will do more testing later this week! Thanks, I appreciate the quick review! ------------- PR Comment: https://git.openjdk.org/jfx/pull/2218#issuecomment-5024062101
