On Tue, 28 Jul 2026 19:29:14 GMT, Andy Goryachev <[email protected]> wrote:
>> Nir Lisker has updated the pull request incrementally with five additional
>> commits since the last revision:
>>
>> - Number
>> - Date/Time
>> - BigDecimal/Integer
>> - Reintroduce conversion methods for primitives
>> - Retrieve default locale on creation
>
> modules/javafx.base/src/main/java/javafx/util/converter/DateTimeStringConverter.java
> line 44:
>
>> 42: /// Reads the default locale at the time of creation. If the default
>> locale is changed during the application's life,
>> 43: /// new converters will use the new default locale.
>> 44: private static final Locale defaultLocale() {
>
> should these methods (also in `BaseTemporalStringConverter`) be moved to a
> utility, maybe in in `com.sun.javafx` ?
> or as package-protected in `BaseStringConverter`
If retrieval of the default locale is done with
`Locale.getDefault(Locale.Category.FORMAT)` in more places in the codebase, it
can be moved there. This is a specific way to get the default locale. It could
be moved to `BaseStringConverter`, but that would imply a standard amongst
string converters (which is true, but there are only 2 use cases). I don't mind
either way.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r3673687625
