On Tue, 11 Aug 2026 19:33:46 GMT, Andy Goryachev <[email protected]> wrote:
> this code is not being hit when scrolling with the mouse. > > should the change in the viewport origin result in VISIBLE_ITEM_RANGE being > updated? Not until the VO requests the data. Which happens when it detects change in the selected row or when we enter/exit the table or list with VO selection shortcuts. > 1. this is a new attribute, so this PR needs as CSR, correct? I have no idea. If that would be a change in the public API i would definitely say yes, for the attribute - since we add it and not changing the meaning of the existing attribute - may be? Gray area for me honestly. @kevinrushforth Any comments? > 2. would it make more sense to use a more descriptive record instead of int[]? That would require more processing on the native side so i would just leave it as is. It is a technical attribute that is required to pass information from the skin level to the native a11y helper - it is not supposed to be available for any other purposes. > minor: the values in this enum are not sorted alphabetically - should they? > do we care? Not really. Changing the existing code just to sort the enum - i would hate to do so, i prefer to keep the history cleaner, it's an old code, technical binding of the parameters to the native bound variables, nobody really looks at it except the compiler. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3761512689 PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3761494212
