On Wed, 5 Aug 2026 21:38:08 GMT, Andy Goryachev <[email protected]> wrote:
>> Fixes double check locking by adding the `volatile` keyword. >> >> During normal operation, the access seems to happen from two threads: >> >> Thread[#29,QuantumRenderer-0,5,main] >> Thread[#34,JavaFX Application Thread,5,main] >> >> >> On one hand, this access is likely to be mutually exclusive, on the other >> hand, javafx does allow the nodes to be created in a background thread, and >> it might be possible to invoke, for example, `GlyphLayout.breakRuns()` from >> a background thread. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Merge branch 'master' into 8387684.volatile > - proper initialization > - volatile @azuev-java could you be the second reviewer? ------------- PR Comment: https://git.openjdk.org/jfx/pull/2205#issuecomment-5334219484
