On Wed, 19 Aug 2026 14:28:13 GMT, Kevin Rushforth <[email protected]> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8305842: Replace qtdemux with MP4 demux based on Media Foundation [v8] > > modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/projects/plugins/gstplugins-lite.c > line 45: > >> 43: !plugin_init_app(plugin) || >> 44: !plugin_init_audioparsers(plugin) || >> 45: !plugin_init_qtdemux(plugin)) > > This used to be called on all platforms. I see you moved this initialization > from a platform-independent call to a Linux-only call. That means it won't be > called for macOS. Since you also removed qtdemux from the mac Makefile, I > presume that this is intentional. Was qtdemux ever used on macOS prior to > this? Yes, we used qtdemux upto jfx20 and usage was removed since JDK-8287822. For some reason I did not cleanup makefiles and plugin registration. On macOS since JDK-8287822 (jfx20) only aiff files are played via GStreamer and rest if via AVFoundation. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2206#discussion_r3817822607
