On Thu, 20 Aug 2026 14:08:25 GMT, Marius Hanl <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> try with > > Just checked other `BufferedImage` occurrences and found `PrismImage`, which > seems to have `getBestBufferedImageType`,`getAssociatedPixelFormat` and > `fromFXImage` as well. Maybe also worth deduplicating? > Hi, I wanted to share my opinion of being strongly against increasing the > dependence on java.desktop module. This is a very large and messy module > filled with things that are unnecessary for javafx apps and things that are > very old as well. Previously @Maran23 suggested deleting the dependency on > this module completely in #1958, which massively reduced application size. > While that was not done yet and may not be done anytime soon, I am strongly > against increasing the coupling. That would make it difficult to compile own > javafx without this module, or something along those lines. > > So please do not increase dependency on java.desktop module Don't worry, this will not increase the coupling to `java.desktop`. It just moves most of the Swing `BufferedImage` code into one class, so that only `javafx.graphics` need to be coupled to `java.desktop`. For a custom fork (I also have one without `java.desktop`), you still just need to remove it from the `module-info` of `javafx.graphics` and `javafx.base`, as before. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2267#issuecomment-5387701294
