On Mon, 24 Aug 2026 15:00:20 GMT, Andy Goryachev <[email protected]> wrote:
>> I get that` javafx.graphics` need to export itself to `javafx.swing` for >> `ImageUtils` >> but after recent changes, nothing from` javafx.swing `is being used in >> `javafx.graphics` so why javafx.swing needs to export itself to >> javafx.graphics...I guess that's redundant, no? >> I think we should remove this line from javafx.swing module-info > > yes, we should be able to remove this export in javafx.swing module-info now Oh, I see what you are asking now. I misunderstood your question before. The conditional export of `com.sun.javafx.embed.swing` is unrelated to the buffered image utilities or this PR. The JavaFX platform startup logic in `PlatformImpl` reflectively calls a method in `com.sun.javafx.embed.swing` if the system property `javafx.embed.singleThread` is set. This is optional and only succeeds is the `javafx.swing` module is loaded (we cannot have a hard dependency on `javafx.swing` from `javafx.graphics`). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2267#discussion_r3844726510
