On Mon, 24 Aug 2026 15:22:52 GMT, Andy Goryachev <[email protected]> wrote:
>> Changes the `BinarySerializer.writeSimpleSelector` to emit sorted >> pseudoclasses' names. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > array list modules/javafx.graphics/src/main/java/com/sun/javafx/css/BinarySerializer.java line 173: > 171: Collection<PseudoClass> pseudoClassStates = > selector.getPseudoClassStates(); > 172: if (pseudoClassStates.size() > 1) { > 173: ArrayList<PseudoClass> sorted = new > ArrayList<>(pseudoClassStates); Minor, if you like: Suggestion: List<PseudoClass> sorted = new ArrayList<>(pseudoClassStates); modules/javafx.graphics/src/main/java/com/sun/javafx/css/BinarySerializer.java line 200: > 198: @Override > 199: public int compare(PseudoClass a, PseudoClass b) { > 200: return > a.getPseudoClassName().compareTo(b.getPseudoClassName()); Also minor, again if you like: This can also be written as a lambda: `(a, b) -> a.getPseudoClassName().compareTo(b.getPseudoClassName());` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2271#discussion_r3844898289 PR Review Comment: https://git.openjdk.org/jfx/pull/2271#discussion_r3844905193
