On Mon, 24 Aug 2026 15:27:46 GMT, Andy Goryachev <[email protected]> wrote:

>> Any internal code that needs to read/write javafx images currently goes 
>> through the `ImageIO` (`java.desktop` module) and the `SwingFXUtils` (in 
>> `javafx.swing` module).
>> 
>> To avoid adding dependencies, we should move the bulk of implementation to 
>> the `javafx.graphics` module which in turn can be used by the `SwingFXUtils` 
>> and other internal code without adding additional explicit dependencies.
>> 
>> This PR moves the `SwingFXUtils` implementation to 
>> javafx.graphics/com.sun.javafx.util.ImageUtils and also adds a utility method
>> 
>> public static byte[] writeImage(Image im, String format) throws IOException
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andy Goryachev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Revert "rm export in swing"
>   
>   This reverts commit bbef1845b906df21cd41a44b470aa4fbbd59475d.

modules/javafx.swing/src/main/java/module-info.java line 47:

> 45: 
> 46:     exports com.sun.javafx.embed.swing to
> 47:         javafx.graphics;

This change is incorrect and must be reverted. It is both unrelated to this fix 
and wrong. See [this 
comment](https://github.com/openjdk/jfx/pull/2267#discussion_r3844726510)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2267#discussion_r3844896078

Reply via email to