On Wed, 26 Aug 2026 23:25:32 GMT, Alexander Matveev <[email protected]> 
wrote:

>> - Added documentation for "resource" protocol.
>> - "resource" protocol was added with JDK-8238755 to support GraalVM 
>> native-image.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Alexander Matveev has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - 8294872: Document "resource" protocol [v4]
>  - 8294872: Document "resource" protocol [v3]

some minor comments, otherwise looks good to me.

modules/javafx.media/src/main/java/javafx/scene/media/Media.java line 365:

> 363:      * for more information about URI formatting in general.
> 364:      * The <code>jar</code> URL syntax is specified in {@link 
> java.net.JarURLConnection}.
> 365:      * <code>jrt</code> URL syntax is specified in <a 
> href="https://openjdk.org/jeps/220";>JEP 220: Modular Run-Time Images</A>.

`</A>` -> `</a>`

modules/javafx.media/src/main/java/javafx/scene/media/Media.java line 366:

> 364:      * The <code>jar</code> URL syntax is specified in {@link 
> java.net.JarURLConnection}.
> 365:      * <code>jrt</code> URL syntax is specified in <a 
> href="https://openjdk.org/jeps/220";>JEP 220: Modular Run-Time Images</A>.
> 366:      * The <code>resource</code> URL syntax is specified in <a 
> href="https://www.graalvm.org/latest/reference-manual/native-image/dynamic-features/URLProtocols/";>URL
>  Protocols in Native Image</a>.

specified -> described

(the reference is neither a spec nor a part of the official java api docs)

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2251#pullrequestreview-5054133765
PR Review Comment: https://git.openjdk.org/jfx/pull/2251#discussion_r3883221890
PR Review Comment: https://git.openjdk.org/jfx/pull/2251#discussion_r3883229474

Reply via email to