On Wed, 2 Sep 2026 09:39:03 GMT, Ambarish Rapte <[email protected]> wrote:

> There is a reference to `gradle.properties` in file 
> `modules/javafx.media/src/main/native/xcode_project/java_home.sh`
> Could you please check if it requires any attention ?

I have a couple of issues here. First, this is a macOS workaround and I can't 
test it. Secondly, I don't know what `JFX_MEDIA_DIR` is. It's set in the 
cryptic 
`/media/src/main/native/xcode_project/JFXMedia.xcodeproj/project.pbxproj` file 
*after* it's read:

JFX_MEDIA_BUILD_DIR = "$(JFX_MEDIA_DIR)/build";
JFX_MEDIA_DIR = ../../../..;

I don't know when this code is run. If it's during the build (doesn't seem like 
it), then a `gradle.properties` file is already irrelevant. If it's a setup for 
the build, and it generates a `gradle.properties` in a subproject, it will 
supposedly override the parent one. There's a discussion on it in 
https://github.com/gradle/gradle/issues/35029.

Does this file still get executed or is it a relic? It also has a fallback to 
1.8, do we still support building on that version?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2240#issuecomment-5508459480

Reply via email to