On Thu, 3 Sep 2026 06:53:57 GMT, Lukasz Kostyra <[email protected]> wrote:

>> Added javadoc to `[Labeled,MenuItem].mnemonicParsing` property, taken from 
>> the `MnemonicInfo` internal class.
>> 
>> A CSR may not be needed since it's a mere clarification and not an API 
>> change, but I am not sure.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Labeled.java line 
> 832:
> 
>> 830:      * control will typically present the mnemonic surrounded by 
>> parentheses.
>> 831:      * The extended mnemonic might be hidden on certain platforms and 
>> only displayed
>> 832:      * then the mnemonic modifier key is pressed.
> 
> `then -> when` I think?

Can you indent the list items, and remove the superfluous `<p>...</p>` and 
`</li>` elements? Formatting lists as flat text makes it _really_ hard to read.

Here's an example:

<ul>
    <li><b>Simple mnemonic</b>: the first character preceded by the first 
{@code _}
        character will be treated as the mnemonic. For example, "E_xit" will 
cause
        ...
    <li><b>Extended mnemonic</b>: an optional representation of a mnemonic is
        {@code _(c)}, where {@code c} is the mnemonic character. For example,
        ...
</ul>

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2287#discussion_r3925546125

Reply via email to