On Mon, 31 Aug 2026 20:35:44 GMT, Andy Goryachev <[email protected]> wrote:
>> I think it would best to ignore this in this PR (it was broken before, it is >> still now), and instead make a follow-up PR that switches round -> rint >> (this was sort of the plan already) as round behaves poorly with our current >> sentinel `Double.MAX_VALUE` or anything else that wouldn't fit in a `long`. >> >> In that same PR, we can remove the `ulp` in the ceiling code, as removing an >> `ulp` from `Double.MAX_VALUE` severely changes the value with no recourse. >> A constant epsilon (that is far smaller than `Double.MAX_VALUE`) would just >> be ignored, ie: >> >> Double.MAX_VALUE - 0.0000001 == Double.MAX_VALUE >> >> But >> >> Double.MAX_VALUE - ulp(Double.MAX_VALUE) >> Double.MAX_VALUE >> >> (with `>>` meaning a lot smaller) > > +1 for `round->rint` and removing the `ScaledMath.round()` in a followup. I've filed [JDK-8391862](https://bugs.openjdk.org/browse/JDK-8391862) Consider replacing deprecated ScaledMath.round() with rint() Any volunteers? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2278#discussion_r3936297709
