On Tue, 1 Sep 2026 16:22:19 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Remove trailing white space
>> - Fix shared pixel buffer notifications and remove dummy Screen
>
> modules/javafx.graphics/src/main/java/javafx/scene/canvas/GraphicsContext.java
> line 1413:
>
>> 1411: else {
>> 1412: try {
>> 1413: path.arcTo(curState.transform, (float) x1, (float) y1,
>> (float) x2, (float) y2, (float) radius);
>
> does it need `markPathDirty()` here?
Yes, it did, fixed. I also noticed that in the SVG append code there was a
pre-existing bug that forgot to mark the path dirty -- fixed that as well.
> modules/javafx.graphics/src/main/java/javafx/scene/image/WritableImage.java
> line 178:
>
>> 176: }
>> 177:
>> 178: context = new SWDrawingContext(img, rect ->
>> bufferDirty(rect));
>
> a single `PixelBuffer` may source multiple `WriteableImage`s, this callback
> invalidates only that owned by the context, leaving the other siblings
> showing stale pixels.
I added a fix for this (via `bufferDirty` in `PixelBuffer`). I also create the
`DrawingContext` now via `Toolkit` which allows me to avoid the exception here
(even though it will never fire) as well as allowing me to test the drawing
context shared buffer scenario via stub toolkit.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3940441641
PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3940439820
