On Sun, 6 Sep 2026 09:53:54 GMT, John Hendrikx <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cache negative declaringClass lookup
>
> modules/javafx.base/src/main/java/javafx/beans/property/SimpleObjectProperty.java
> line 132:
>
>> 130: public SimpleObjectProperty(Object bean, Class<?> declaringClass,
>> String name) {
>> 131: this(bean, name);
>> 132: this.declaringClass = declaringClass;
>
> One could pass in `declaringClass` here as `null`
>
> - Should we allow this?
> - If so, what does it mean?
> - `null` means look-up just in time
> - `null` means don't look this up, it is intended to not be specified
Good question! I see no reason to second-guess the user of this API. If they
explicitly specify `null` as the declaring class, then so be it. This can't
happen accidentally for unsuspecting code, as these are new constructor
overloads.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2015#discussion_r3944079936
