On Thu, 27 Aug 2026 12:45:15 GMT, Michael Strauß <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 43 commits: >> >> - Merge branch 'master' into 8354943_v2 >> - mapped = true for popups >> - Do not block sent configure events, as doing so breaks screen-change >> detection. >> - - Restore gdk_event_request_motions (it's needed even without event >> compression) >> - Remove cursor unref (it's aready de-referenced on gdk_window_set_cursor) >> - Improve XComposite message >> - Remove configurable delays >> - Fix test >> - Xorg fixes >> - Revert "Rewrite WrongStageFocusWithApplicationModalityTest because it >> fails intermittently" >> >> This reverts commit c6b9dd745e5d762adb89a3b596e53b0d8a790d7f. >> - Rewrite WrongStageFocusWithApplicationModalityTest because it fails >> intermittently >> - Use existing verbose flag for GTK >> - ... and 33 more: https://git.openjdk.org/jfx/compare/58a7bea2...969ed5f3 > > modules/javafx.graphics/src/main/native-glass/gtk/GlassApplication.cpp line > 549: > >> 547: case GDK_MAP: >> 548: ctx->process_map(); >> 549: break; > > Is this really intended? The previous implementation passed `GDK_MAP` to > `gtk_main_do_event()`. Other GTK-managed events in the new implementation > still do so, but map events are now intercepted completely. This suppresses > the widget’s `map-event` signal and the default `GtkWindow` map handler. > > Maybe we should dispatch to GTK: > > case GDK_MAP: > gtk_main_do_event(event); > ctx->process_map(); > break; I don’t remember the reasoning behind this change. I've put it back and will run systemTests to verify any possible issue. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r3944654061
