On Fri, 4 Sep 2026 11:53:50 GMT, Marius Hanl <[email protected]> wrote:
>> This is an idea to move out the `:apps` build from the `build.gradle`. >> And to add an `INCLUDE_APPS` flag, that is `true` by default to control >> whether we actually want to build the `:apps` when running `gradle all` or >> if we actually need to clean them when running `gradle clean`. >> >> I see two advantages: >> - IMO, the main `build.gradle` should focus on JavaFX and not so much on >> anything else, like apps >> - As of now, when I did run `gradle clean`, I always need to install `Ant`, >> just because the apps are also cleaned which I did not even build before. >> This is problematic, because: >> - I think most of the people do not have `Ant`, it is very rarely used >> nowadays >> - It is also not preinstalled in pretty much every OS / distribution I >> tried. And I usually only installed for `OpenJFX` and never need it for >> anything else. If possible, it would be good if this is not needed if you >> just want to run tests and build JavaFX >> - For reference, when running CachyOS I could just build JavaFX out of >> the box without ever installing anything. This is a very nice experience >> and should help people to contribute. The only thing I did run into was, >> well, `Ant` when running `gradle clean` >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > change default to true The change looks fine, however, since I'm working on the build file as a whole, it will be easier for me if the file is not split at this point. The flag that allows to turn off apps is fine; the split is something I'd like to wait with. As a side note, both `swt` and `swing` have flags that turn off building them (in an odd wait, albeit). I'm not sure if those are still needed and what the reasoning is behind needing to turn off specifically these modules. ------------- PR Review: https://git.openjdk.org/jfx/pull/2291#pullrequestreview-5186928503
