On Fri, 11 Sep 2026 13:24:10 GMT, Ziad El Midaoui <[email protected]> wrote:
> Improved the manual test instructions and pass/fail criteria for the > following tests : > > - NotResizableWindowTest > - DndBasic > - DndTestDragViewRawImage > - PrintDialogModalityTest > - PrintOrientTest > - StartIconified > - DragDropFromSwingComponentInSwingNodeTest > - DragDropOntoJavaFXControlInJFXPanelTest > - EmojiTest > - EventListenerLeak > - InputTypeAcceptAttributeTest > - GifImageTestApp > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). some ideas tests/manual/dnd/DndBasic.java line 110: > 108: } > 109: > 110: return "Drag from a green Source to a blue Destination. The > desktop applications may " + text block? tests/manual/printing/PrintDialogModalityTest.java line 40: > 38: > 39: static final String infoText = > 40: "PRECONDITION: At least one printer must be installed. \n" + I would recommend a textblock here as well tests/manual/printing/PrintOrientTest.java line 71: > 69: > 70: static final String instructions = > 71: "This test verifies paper orientation for all supported > cases: " + I would recommend a textblock tests/manual/printing/PrintOrientTest.java line 109: > 107: Button print = new Button("Print"); > 108: print.setLayoutX(80); > 109: print.setLayoutY(300); Setting a manual layout is almost always a bad idea, usually just using a box and alignment is better tests/manual/swing/DragDropFromSwingComponentInSwingNodeTest.java line 86: > 84: > 85: VBox rootNode = new VBox(6, > 86: new Label("1. This test verifies drag-and-drop from a > Swing component inside a SwingNode."), One `Label` with a textblock? And the other `Label`s below? ------------- PR Review: https://git.openjdk.org/jfx/pull/2315#pullrequestreview-5179248622 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r3989665077 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r3989659159 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r3989658033 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r3989689280 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r3989662699
