On Mon, 21 Sep 2026 21:08:15 GMT, Nir Lisker <[email protected]> wrote:
>> Update for the 3D lighting test tool as described in the JBS issue. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Nir Lisker has updated the pull request incrementally with four additional > commits since the last revision: > > - Added a guide > - Add screenshot javadoc > - Add gitignore > - Remove expand arrow from ambient light thank you for making the changes! one minor comment about .gitignore file forgot to ask - are you going to switch to the text buttons? tests/performance/3DLighting/.gitignore line 1: > 1: screenshots/ missing newline? not an issue if git understands it, but github shows a marker. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1387#pullrequestreview-5272140366 PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-5767960400 PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r4066678127
