On Wed, 6 Mar 2024 16:32:12 GMT, Ambarish Rapte <[email protected]> wrote:
>> Update for the 3D lighting test tool as described in the JBS issue. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > An observation out of scope of this PR. > The effect of lighting on mesh vs a box is quite different. > Notice the screenshot, left side is a Box and right side is Mesh, both have > Magenta SpotLight. > I think the effect of light should be same on a 2D surface, and the effect on > Box seems correct to me. > Another observation: The effect of light on Mesh is different with 100 > divisions than 200+ divisions. > > <img width="1440" alt="Screenshot 2024-03-06 at 3 36 09 PM" > src="https://github.com/openjdk/jfx/assets/11330676/5d7b3025-35f5-43b8-9f41-edea8d68c824";> @arapte @jayathirthrao @lukostyra Can one of you be the second reviewer? ------------- PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-5779988142
