On Wed, 23 Sep 2026 16:34:05 GMT, Marius Hanl <[email protected]> wrote:
>> This PR integrates the `Platform` functionality into `PlatformUtil`, so that >> we only have one place where we do OS stuff. And can delete `Platform`. >> >> Something that was first discussed in >> https://github.com/openjdk/jfx/pull/1864 and I also saw when I did the >> cleanup some months ago in PR https://github.com/openjdk/jfx/pull/2190. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Marius Hanl has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 10 additional > commits since the last revision: > > - Merge branch 'master' of https://github.com/openjdk/jfx into > 8365309-move-PlatformUtil-to-javafx.graphics > - proper getter now > - Move platform factory to GlassPlatform > - Move accessible handling to GlassPlatform > - Move headless, egl embedded type (now monocle) to GlassPlatform > - rename to GlassPlatform, improve code a bit > - revert back > - Revert "Move PlatformUtil from javafx.base to javafx.graphics" > > This reverts commit e41e8ed504b9ac54d8be7646108151f5aeff07d3. > - Move PlatformUtil from javafx.base to javafx.graphics > - 8365309: move PlatformUtil to javafx.graphics I forgot to send the comment: The `isEmbedded` check should be moved to `GlassPlatform`, as suggested. But before, I want to have a closer look on the last usage in `javafx.controls`. I think we might can remove it from there and therefore do not need a utility class just for that case. As we have no hurry regarding this PR, I will have a look and, once decided, update this PR (or move it in a follow-up). ------------- PR Comment: https://git.openjdk.org/jfx/pull/2299#issuecomment-5805004449
