On Wed, 23 Sep 2026 12:23:55 GMT, Nir Lisker <[email protected]> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Implement notifying boolean
>
> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java 
> line 87:
> 
>> 85:  *     <li>Properties in the JavaFX library invalidate when the value 
>> they hold
>> 86:  *         changes. Object properties compare the new value by 
>> reference, so they also
>> 87:  *         invalidate when the new value is equal to the previous value 
>> but not the
> 
> "is equal" is a bit ambiguous here. I would use "`equals`" to clarify.

Clarified with `{@link Object#equals(Object) equals}`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r4112087160

Reply via email to