On Thu, 1 Oct 2026 21:10:20 GMT, Nir Lisker <[email protected]> wrote:

>> Update for the 3D lighting test tool as described in the JBS issue.
>> 
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Nir Lisker has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix typo

lgtm, left a minor suggestion for readme.

tests/performance/3DLighting/README.md line 21:

> 19: Run `app.LightingApplication` with the following VM options (which are 
> pre-configured in `build.gradle`):
> 20: ```properties
> 21: 
> -Djava.library.path="\path\to\jfx\modules\javafx.graphics\build\module-lib"

can you use relative path?  in eclipse, that would be relative to the project 
root.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1387#pullrequestreview-5393073866
PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r4166743253

Reply via email to