On Wed, 7 Oct 2026 22:43:57 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 14 commits: >> >> - Merge branch 'master' into 8388276.import.images >> - Merge branch 'master' into 8388276.import.images >> - spelling >> - Merge branch 'master' into 8388276.import.images >> - copied from swing fx utils >> - Merge branch 'master' into 8388276.import.images >> - images >> - lossless >> - Merge branch 'master' into 8388276.import.images >> - whitespace >> - ... and 4 more: https://git.openjdk.org/jfx/compare/eab83a4b...b4c734c2 > > modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyledTextModel.java > line 456: > >> 454: li.onContentChange(ch); >> 455: } >> 456: markers.update(start, end, charsTop, linesAdded, charsBottom); > > A listener that reads the marker will now see the old value rather than the > new. This is a behavioral change that goes beyond image import. Is this a > necessary part of adding support for importing images? If not, it should be > reverted. If it is, it should be called out in the CSR. It was a bug discovered during the image import development. I will update the `Marker` doc, I think it's ok to include this change in this PR, since it's an incubator. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2224#discussion_r4233495874
