On Tue, 13 Oct 2026 15:36:47 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> unsettable property
>
> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line
> 1006:
>
>> 1004: CssMetaData cssMetaData = entry.getKey();
>> 1005: try {
>> 1006: resetToInitialValue(styleable, cssMetaData,
>> entry.getValue());
>
> `resetToInitialValue()` might throw (in `applyStyle`), the entry is already
> removed on L996. this makes it impossible to retry the reset after the
> condition is cleared, causing the previous value to remain.
>
> should the entry be removed only after a successful reset?
If anything, this is a preexisting issue. Again, I just reuse the already
existing reset method. It did not do that.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2343#discussion_r4261297334
