On Wed, 14 Oct 2026 21:12:26 GMT, Andy Goryachev <[email protected]> wrote:
>> Enables importing of images from the clipboard into the RichTextModel by >> adding a data format handler for the DataFormat.IMAGE mime type. >> >> This change includes new utility added by >> [JDK-8390345](https://bugs.openjdk.org/browse/JDK-8390345). >> >> Note: the banana slug image is a public domain added with author's >> permission [0]. >> >> ## References >> >> [0] https://en.wikipedia.org/wiki/Banana_slug >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > whitespace Code changes look good. I confirm that the new test fails before the latest change and passes after. One more doc comment (revert all changes to Marker.java), and then it's ready to go. Update the CSR and I'll review that, too. modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/Marker.java line 69: > 67: * <p> > 68: * The value of this property gets updated after the model listeners > receive their > 69: * {@code ContentChange} events. Suggestion: To clarify my earlier comment, this documentation doesn't belong anywhere in this file. Marker is a data object. A specification about one particular client's (`Listener.onContentChange()`, in this case) use of that data object belongs at the use site and not here. Since you already added a note there, nothing is needed here. ------------- PR Review: https://git.openjdk.org/jfx/pull/2224#pullrequestreview-5537423710 PR Review Comment: https://git.openjdk.org/jfx/pull/2224#discussion_r4286290530
