On Wed, 19 Aug 2026 00:54:49 GMT, Michael Strauß <[email protected]> wrote:
> SplitPaneSkin's measurement and layout calculations are not correct when > pixel-snapping is enabled. There are quite a lot of mistakes that were made, > so this PR is quite large. Here is a list of what's changed: > > 1. Fixed X/Y snapping and cumulative re-snapping. > 2. Preserved fractional behavior when `snapToPixel` is false. > 3. Fixed content insets, clips, dragging, resizing, and divider positioning. > 4. Fixed bounded content-biased measurements. > 5. Fixed proportional layout below minimum size. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I still think that the virtual layout containers PR has little do with snapping, aside from some of the layout code being rehomed. Nothing that a merge couldn't fix. Also, I think we need to make a decision on what `snapToPixel` means -- is it for just that single `Node`, and then having child nodes fighting a hopeless battle to get "snapping" again when contained within an unsnapped parent, or does it mean "turn off snapping for this node and all sub nodes" (much more sensible) similar to how visible and enabled behave. If the above point is resolved in favor of the second option, then snapping code adjustments become simpler (no need to compensate for an unsnapped parent when the current node is snapped). ------------- PR Comment: https://git.openjdk.org/jfx/pull/2263#issuecomment-6199567430
