On Fri, 16 Oct 2026 16:00:36 GMT, Andy Goryachev <[email protected]> wrote:
>> A trivial bugfix in `ListenerHelper`. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > tests Two nitpicks. modules/javafx.controls/src/test/java/test/javafx/scene/control/TestListenerHelper.java line 404: > 402: }; > 403: IDisconnectable d = h.addEventHandler(item, MouseEvent.ANY, > li); > 404: WeakReference<Object> ref = new WeakReference(d); Suggestion: WeakReference<Object> ref = new WeakReference<>(d); Otherwise I get a warning here, which we can easily avoid. modules/javafx.controls/src/test/java/test/javafx/scene/control/TestListenerHelper.java line 451: > 449: }; > 450: IDisconnectable d = h.addEventFilter(item, MouseEvent.ANY, > li); > 451: WeakReference<Object> ref = new WeakReference(d); Suggestion: WeakReference<Object> ref = new WeakReference<>(d); ------------- PR Review: https://git.openjdk.org/jfx/pull/2345#pullrequestreview-5551120186 PR Review Comment: https://git.openjdk.org/jfx/pull/2345#discussion_r4297233456 PR Review Comment: https://git.openjdk.org/jfx/pull/2345#discussion_r4297234580
