On Fri, 16 Oct 2026 18:58:08 GMT, Marius Hanl <[email protected]> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>>  line 2857:
>> 
>>> 2855:             cell.setVisible(false);
>>> 2856:             if (cell.getIndex() != -1) {
>>> 2857:                 cell.updateIndex(-1);
>> 
>> we need to check whether the focus has moved elsewhere, for example in an 
>> `onEDitCancel` handler, otherwise L2870 will steal the focus back from where 
>> it was moved by the handler.
>
> I do had already nearly a year ago another idea how to solve this. Because 
> this is all but not good.
> 
> I will push a change where I would like to know your opinion.

This is the approach I found out in https://github.com/openjdk/jfx/pull/2051 
back then.
I do think it is anyway more clean and may help to resolve your comment in 
https://github.com/openjdk/jfx/pull/2308 as well.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2347#discussion_r4298302663

Reply via email to