On Mon, 19 Oct 2026 15:17:31 GMT, Andy Goryachev <[email protected]> wrote:
> Fixed incorrect handling of the surrogate pairs in `GlyphLayout.breakRuns()`. > > Reviewers: @prrace @Ziad-Mid > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Tested on Linux, works! Some comments for the test and the `complex` flag. modules/javafx.graphics/src/main/java/com/sun/javafx/text/GlyphLayout.java line 271: > 269: if (complex) { > 270: flags |= FLAGS_HAS_COMPLEX; > 271: complex = false; `complex` is set to `false` here, but used again below. Is that a problem? Looks very weird to me. modules/javafx.graphics/src/test/java/test/javafx/text/TestGlyphLayoutBreakRuns.java line 38: > 36: > 37: /** > 38: * empty javadoc? modules/javafx.graphics/src/test/java/test/javafx/text/TestGlyphLayoutBreakRuns.java line 42: > 40: public class TestGlyphLayoutBreakRuns { > 41: > 42: record TC(String text, int ... runs) { } What is a `TC`? modules/javafx.graphics/src/test/java/test/javafx/text/TestGlyphLayoutBreakRuns.java line 56: > 54: @ParameterizedTest > 55: @MethodSource("breakRunsSource") > 56: public void testBreakRunsSurrogatePairsAdlam(TC tc) { And what is an adlam? Shall we add the JDK ticket and a small description (one sentence) as javadoc for the test? ------------- Changes requested by mhanl (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2349#pullrequestreview-5583187832 PR Review Comment: https://git.openjdk.org/jfx/pull/2349#discussion_r4323517234 PR Review Comment: https://git.openjdk.org/jfx/pull/2349#discussion_r4323444556 PR Review Comment: https://git.openjdk.org/jfx/pull/2349#discussion_r4323446944 PR Review Comment: https://git.openjdk.org/jfx/pull/2349#discussion_r4323454484
