On Mon, 19 Oct 2026 23:03:05 GMT, Jose Pereda <[email protected]> wrote:
> This PR fixes an intermittent failing system test. > > On slow runs, calling `stage::show` and then Platform.runLater(stage::close)` > before the test started could cause that the assertion in `stage.isShowing()` > failed, if the test started after the stage was already closed. > > Moving the call to close the stage to the test guarantees that the failing > assertion passes, fixing the intermittent failure, while not altering the > rest of the test. > > --------- > - [X] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). LGTM I simulated the race condition by adding a sleep at the beginning of the test method. It fails without the fix and passes with the fix. As a simple test fix, a single reviewer is sufficient, but wait until it's been 24 hours in case someone else wants to take a look. ------------- Marked as reviewed by kcr (Lead). PR Review: https://git.openjdk.org/jfx/pull/2350#pullrequestreview-5584856231
