On Thu, 15 Oct 2026 20:03:57 GMT, Andy Goryachev <[email protected]> wrote:

>> Enables importing of images from the clipboard into the RichTextModel by 
>> adding a data format handler for the DataFormat.IMAGE mime type.
>> 
>> This change includes new utility added by 
>> [JDK-8390345](https://bugs.openjdk.org/browse/JDK-8390345).
>> 
>> Note: the banana slug image is a public domain added with author's 
>> permission [0].
>> 
>> ## References
>> 
>> [0] https://en.wikipedia.org/wiki/Banana_slug
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andy Goryachev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   restore stderr

Code-wise looks good, tests also run correctly. I've been testing these changes 
and had some issues when playing around with RichEditorDemo, I cannot get the 
copied image to show after pasting.

Steps I did:
1. Open any image, ex. this link - 
https://thumb.wikimedia.org/wikipedia/commons/thumb/b/bb/Kittyply_edit1.jpg/500px-Kittyply_edit1.jpg
 - in browser
2. Right-click > Copy Image
3. `gradle build` this change, `cd apps/samples/RichTextAreaDemo` and run `ant 
run-richeditor-demo`
4. Try pasting

On my end something definitely gets pasted - the paragraph grows and the cursor 
gets large - but the image cannot be seen:
<img width="773" height="593" alt="image" 
src="https://github.com/user-attachments/assets/c2a6fda9-e5ac-4a8a-96b4-2aae179dfe3a";
 />

Not sure if this is a problem of this change or the Rich Editor Demo having 
issues. If it's the latter, it can go through a follow-up.

-------------

PR Review: https://git.openjdk.org/jfx/pull/2224#pullrequestreview-5585348278

Reply via email to