On Wed, 21 Oct 2026 20:38:49 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains five commits: >> >> - comment >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8392117-VirtualFlow-may-end-up-creating-1-2-unnecessary-cells >> >> # Conflicts: >> # >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java >> - bulk remove >> - adjust copyright, remove import >> - 8392117: VirtualFlow may end up creating 1-2 unnecessary cells > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java > line 2874: > >> 2872: >> 2873: if (removedCells != null) { >> 2874: sheetChildren.removeAll(removedCells); > > we still have a regression: a freshly released cell with index=-1 can be > reused by a listener (if a listener scrolls, for example). but we are removing before, we are removing now. How can this regress? If a listener scrolls, layout should be called again because there is much more to do. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2308#discussion_r4342005959
