On Wed, 21 Oct 2026 17:21:17 GMT, Philemon Hilscher <[email protected]> wrote:
>> This fixes the issue adressed here >> https://bugs.openjdk.org/browse/JDK-8222454 >> >> The added TreeTableViewTests were failing without the main code changes. I >> added the other tests to ensure the consistent functionality of related cell >> based components. >> The method getItemCount() needed to be moved to CellBehaviorBase to do the >> necessary index check in doSelect() below. All subclasses now implement this >> method based on the cell container. >> >> There is still some refactoring potential here, to reduce code duplications >> and ensure consistent behavior of all cell based components. This could be >> done in a follow-up PR. >> >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Philemon Hilscher has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains five commits: > > - Merge branch 'master' into > JDK-8222454-fix-nullpointer-in-treetablerowbehavior > - 8222454: Review fixes > > Signed-off-by: Philemon Hilscher <[email protected]> > - Merge branch 'master' into > JDK-8222454-fix-nullpointer-in-treetablerowbehavior > - 8222454: Review fixes > > Signed-off-by: Philemon Hilscher <[email protected]> > - 8222454: Fix nullpointer in TreeTableRowBehavior > > Signed-off-by: Philemon Hilscher <[email protected]> I think I am too early with the review. Please address the comments and request re-review. modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java line 6755: > 6753: assertDoesNotThrow(() -> mouse.fireMousePressAndRelease(2)); > 6754: } > 6755: whitespace error modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java line 7964: > 7962: assertDoesNotThrow(() -> mouse.fireMousePressAndRelease(2)); > 7963: } > 7964: inadvertently removed `@Test` annotation. please be more careful. ------------- Changes requested by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2129#pullrequestreview-5606192131 PR Review Comment: https://git.openjdk.org/jfx/pull/2129#discussion_r4341951718 PR Review Comment: https://git.openjdk.org/jfx/pull/2129#discussion_r4341967066
