On Wed, 28 Oct 2026 18:00:52 GMT, Andy Goryachev <[email protected]> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8392158 Split a span's min among rows that don't exceed their share > > modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line > 2692: > >> 2690: index += own[j - i.begin] ? 0 : 1; >> 2691: } >> 2692: double propSize = segment(rest, count, >> index, pixelSize); > > there might be a case where the layout overflows: > - scale=1.0, no gaps > - three rows, first row set at 20% > - each row contains a child, with pref=200 and minimums set to 0, 80, 0 > - spanning child min=100, pref=100 there might be another regression case with biased content: - 2 rows, 3 columns, no gaps - column minimums 80, 0, 0, pref = 80, 200, 200 - first row: a FlowPane, prefWrapLength=10, prefHeight=20, containing two 50x10 rectangles - set grid width to 90 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2312#discussion_r4414245579
