On Wed, 28 Oct 2026 10:15:34 GMT, Lukasz Kostyra <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Ungrab focus when hiding the window, so IME does not try to use it after >> closed > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 65: > >> 63: delete ctx; >> 64: } >> 65: // else: ctx will be deleted in EventsCounterHelper after completing > > Would `shared_ptr<WindowContext>` be a better fit here? This way it can be > owned by both sides and it will be removed once both sides clear it. This is how it works on `master`, so I’d rather leave it as is for now, since this PR is already quite large. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r4436642426
