On Thu, 25 Jun 2026 07:16:08 GMT, Lukasz Kostyra <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> mapped = true for popups
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_general.h line 278:
>
>> 276:
>> 277: #define LOG(category, artifact, fmt, ...) \
>> 278: log(category, #category, artifact, fmt, ##__VA_ARGS__)
>
> I think this `log` call should be wrapped in a `do {} while(0)` block, so:
>
>
> #define LOG(category, artifact, fmt, ...) do {\
> log(category, #category, artifact, fmt, ##__VA_ARGS__); \
> } while(0)
Done
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 117:
>
>> 115:
>> 116: bool operator==(const Rectangle& other) const {
>> 117: return x == other.x && y == other.y
>
> Minor: similar to `OptionalAxisPoint` this could return a not-`operator!=`
Done
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 130:
>
>> 128:
>> 129: bool operator==(const Size& other) const {
>> 130: return width == other.width && height == other.height;
>
> Minor: similar to `OptionalAxisPoint` this could return a not-`operator!=`
Done
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.h line 165:
>
>> 163:
>> 164: bool operator==(const Point& other) const {
>> 165: return x == other.x && y == other.y;
>
> Minor: similar to `OptionalAxisPoint` this could return a not-`operator!=`
Done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r4436805479
PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r4436805197
PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r4436804901
PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r4436804659
