On Fri, 30 Oct 2026 13:55:05 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comment: utility method > > buildSrc/src/main/groovy/com/sun/javafx/gradle/CCTask.groovy line 57: > >> 55: prjEnv.put(key.toString(), value.toString()); >> 56: } >> 57: projectEnv = Collections.unmodifiableMap(prjEnv); > > Minor suggestion: since this appears three times (and will be four once D3D12 > is integrated), do you think it's worth moving this into a utility method in > the base class that takes a Map (`project.WINDOWS_NATIVE_COMPILE_ENVIRONMENT` > in this case) and returns an unmodifiable Map? It's only 4 lines of code, so > I'll leave it up to you. Since you've already tested it, it might not be > worth it. Updated the PR with this change to add a utility method, verified build on mac machine. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2357#discussion_r4440397112
