On Mon, 2 Nov 2026 16:08:06 GMT, Lukasz Kostyra <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request now contains 58 commits:
>>
>> - Merge branch 'master' into 8354943_v2
>> - Revert "[Linux] Robot: screencast restore token is wrongly assumed to be
>> a UUID"
>>
>> This reverts commit 6230bca16d5f80e776b2c53e81a5d768422949e0.
>> - Revert "[Linux] Robot: screencast restore token is wrongly assumed to be
>> a UUID"
>>
>> This reverts commit fa58a4e923d78f8aef6b84395e4a2318ab37bb3a.
>> - Merge branch '8396109' into 8354943_v2
>> - [Linux] Robot: screencast restore token is wrongly assumed to be a UUID
>> - [Linux] Robot: screencast restore token is wrongly assumed to be a UUID
>> - glass_window_ime.cpp: check for null jview
>> glass_window.h: review suggestions
>> glass_general.h: wrap log on a do {} while(0)
>> - - Ungrab focus when hiding the window, so IME does not try to use it
>> after closed
>> - - Avoid null title
>> - Nested changes can happen if java reacts to the change
>> - Extended stages with no view, call base.
>> - Merge branch 'master' into 8354943_v2
>>
>> # Conflicts:
>> # tests/system/src/test/java/test/util/Util.java
>> - ... and 48 more: https://git.openjdk.org/jfx/compare/0165faf6...47605b4a
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkWindow.java
> line 133:
>
>> 131: protected boolean _minimize(long ptr, boolean minimize) {
>> 132: minimizeImpl(ptr, minimize);
>> 133: notifyStateChanged(WindowEvent.MINIMIZE);
>
> I have a question about this part - `notifyStateChanged` also internally
> called `Window.notifyResize` to update the Window's internal state
> immediately. At this point I think the state change relies on GTK processing
> the event loop. Shouldn't at least the `notifyResize` call still remain here
> just to keep Window's internal state up-to-date?
It's not guaranteed that the window manager/compositor will minimize the
window, especially given the wide variety of options available on Linux.
See https://docs.gtk.org/gtk3/method.Window.iconify.html
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r4493341056
