On Tue, 3 Nov 2026 12:58:10 GMT, Marius Hanl <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/native-glass/gtk/screencast_portal.c line 72:
>
>> 70: gboolean isValid = g_utf8_validate(token, -1, NULL);
>> 71: if (!isValid) {
>> 72: DEBUG_SCREENCAST("!!! restore token is not valid UTF-8\n", NULL);
>
> IMO, wen can remove the weird triple `!!!`
>
> Suggestion:
>
> DEBUG_SCREENCAST("restore token is not valid UTF-8\n", NULL);
>
>
> Also, shall we still log the token? Now we would not anymore.
Removed the "!!!" prefix (although it is still used elsewhere) and added the
token to the log.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2356#discussion_r4469780779
